M1.1 : nettoyer le code

src/Controller/FormationsController.php

@@ -26,8 +26,9 @@ class FormationsController extends AbstractController {
      * @var CategorieRepository
      */
     private $categorieRepository;
+    private $formationPage = "/pages/formations.html.twig";
     
-    function __construct(FormationRepository $formationRepository, CategorieRepository $categorieRepository) {
+    public function __construct(FormationRepository $formationRepository, CategorieRepository $categorieRepository) {
         $this->formationRepository = $formationRepository;
         $this->categorieRepository= $categorieRepository;
     }
@@ -36,7 +37,7 @@ class FormationsController extends AbstractController {
     public function index(): Response{
         $formations = $this->formationRepository->findAll();
         $categories = $this->categorieRepository->findAll();
-        return $this->render("pages/formations.html.twig", [
+        return $this->render($this->formationPage, [
             'formations' => $formations,
             'categories' => $categories
         ]);
@@ -46,7 +47,7 @@ class FormationsController extends AbstractController {
     public function sort($champ, $ordre, $table=""): Response{
         $formations = $this->formationRepository->findAllOrderBy($champ, $ordre, $table);
         $categories = $this->categorieRepository->findAll();
-        return $this->render("pages/formations.html.twig", [
+        return $this->render($this->formationPage, [
             'formations' => $formations,
             'categories' => $categories
         ]);
@@ -57,7 +58,7 @@ class FormationsController extends AbstractController {
         $valeur = $request->get("recherche");
         $formations = $this->formationRepository->findByContainValue($champ, $valeur, $table);
         $categories = $this->categorieRepository->findAll();
-        return $this->render("pages/formations.html.twig", [
+        return $this->render($this->formationPage, [
             'formations' => $formations,
             'categories' => $categories,
             'valeur' => $valeur,

src/Controller/PlaylistsController.php

@@ -33,8 +33,9 @@ class PlaylistsController extends AbstractController {
      * @var CategorieRepository
      */
     private $categorieRepository;
+    private $playlistPage = "/pages/playlists.html.twig";
     
-    function __construct(PlaylistRepository $playlistRepository, 
+    public function __construct(PlaylistRepository $playlistRepository,
             CategorieRepository $categorieRepository,
             FormationRepository $formationRespository) {
         $this->playlistRepository = $playlistRepository;
@@ -62,9 +63,11 @@ class PlaylistsController extends AbstractController {
             case "name":
                 $playlists = $this->playlistRepository->findAllOrderByName($ordre);
                 break;
+            default:
+                break;
         }
         $categories = $this->categorieRepository->findAll();
-        return $this->render("pages/playlists.html.twig", [
+        return $this->render($this->playlistPage, [
             'playlists' => $playlists,
             'categories' => $categories
         ]);
@@ -75,7 +78,7 @@ class PlaylistsController extends AbstractController {
         $valeur = $request->get("recherche");
         $playlists = $this->playlistRepository->findByContainValue($champ, $valeur, $table);
         $categories = $this->categorieRepository->findAll();
-        return $this->render("pages/playlists.html.twig", [
+        return $this->render($this->playlistPage, [
             'playlists' => $playlists,
             'categories' => $categories,
             'valeur' => $valeur,

src/Entity/Formation.php

@@ -15,7 +15,7 @@ class Formation
     /**
      * Début de chemin vers les images
      */
-    private const cheminImage = "https://i.ytimg.com/vi/";
+    private const CHEMINIMAGE = "https://i.ytimg.com/vi/";
         
     #[ORM\Id]
     #[ORM\GeneratedValue]
@@ -110,12 +110,12 @@ class Formation
 
     public function getMiniature(): ?string
     {
-        return self::cheminImage.$this->videoId."/default.jpg";
+        return self::CHEMINIMAGE.$this->videoId."/default.jpg";
     }
 
     public function getPicture(): ?string
     {
-        return self::cheminImage.$this->videoId."/hqdefault.jpg";
+        return self::CHEMINIMAGE.$this->videoId."/hqdefault.jpg";
     }
     
     public function getPlaylist(): ?playlist

src/Repository/FormationRepository.php

@@ -31,11 +31,11 @@ class FormationRepository extends ServiceEntityRepository
     /**
      * Retourne toutes les formations triées sur un champ
      * @param type $champ
-     * @param type $ordre
+     * @param string $ordre
      * @param type $table si $champ dans une autre table
      * @return Formation[]
      */
-    public function findAllOrderBy($champ, $ordre, $table=""): array{
+    public function findAllOrderBy($champ, string $ordre, $table=""): array{
         if($table==""){
             return $this->createQueryBuilder('f')
                     ->orderBy('f.'.$champ, $ordre)
@@ -82,10 +82,10 @@ class FormationRepository extends ServiceEntityRepository
     
     /**
      * Retourne les n formations les plus récentes
-     * @param type $nb
+     * @param int $nb
      * @return Formation[]
      */
-    public function findAllLasted($nb) : array {
+    public function findAllLasted(int $nb) : array {
         return $this->createQueryBuilder('f')
                 ->orderBy('f.publishedAt', 'DESC')
                 ->setMaxResults($nb)

src/Repository/PlaylistRepository.php

@@ -31,7 +31,7 @@ class PlaylistRepository extends ServiceEntityRepository
     /**
      * Retourne toutes les playlists triées sur le nom de la playlist
      * @param type $champ
-     * @param type $ordre
+     * @param string $ordre
      * @return Playlist[]
      */
     public function findAllOrderByName($ordre): array{